Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings on non-scroll containers should have inherit_bindings=False #2331

Closed
willmcgugan opened this issue Apr 19, 2023 · 1 comment · Fixed by #2337
Closed

Bindings on non-scroll containers should have inherit_bindings=False #2331

willmcgugan opened this issue Apr 19, 2023 · 1 comment · Fixed by #2337
Assignees
@davep
Labels
enhancement New feature or request Task

Comments

@willmcgugan
Copy link
Collaborator

Containers which don't scroll, shouldn't inherit bindings from Widget.
@davep davep mentioned this issue Apr 19, 2023
Closed
@davep davep self-assigned this Apr 19, 2023
@davep davep added enhancement New feature or request Task labels Apr 19, 2023
@davep davep mentioned this issue Apr 19, 2023
Closed
@davep davep changed the title Bindings on containers should have inherit_bindings=False Bindings on non-scroll containers should have inherit_bindings=False Apr 20, 2023
davep added a commit to davep/textual that referenced this issue Apr 20, 2023
@davep
Change all containers so they don't inherit bindings
8a909b0 
This is, to some degree, rendered moot by Textualize#2332, but for the moment it still
feels worth doing. The initial intention was to make sure that non-scrolling
containers and their child classes don't have bindings that may mask other
uses for navigation keys. However, it was realised that the "problem"
affected more than just containers (hence Textualize#2332).

But... on the off chance we add any more default bindings to
`Widget` (unlikely, but still), this will mean that they don't leak into the
containers unless we intend them to.

See Textualize#2331.
@davep davep linked a pull request Apr 20, 2023 that will close this issue
Move default scroll navigation keys out of Widget and into ScrollableContainer #2337
Merged
@davep davep mentioned this issue Apr 20, 2023
Merged
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move default scroll navigation keys out of Widget and into ScrollableContainer davep/textual
2 participants
@davep @willmcgugan