Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable doesn't update styles when component classes are changed with hot-reloading #3312

Closed
rodrigogiraoserrao opened this issue Sep 15, 2023 · 3 comments · Fixed by #3313
Closed

DataTable doesn't update styles when component classes are changed with hot-reloading #3312

rodrigogiraoserrao opened this issue Sep 15, 2023 · 3 comments · Fixed by #3313
Assignees
@rodrigogiraoserrao
Labels
bug Something isn't working

Comments

@rodrigogiraoserrao
Copy link
Contributor

If you change the data table cursor component style .datatable--header with hot reloading, then the style update isn't applied properly.
I suspect this is transversal to all other component classes and it's related to the dead coroutine _on_styles_updated.
@rodrigogiraoserrao rodrigogiraoserrao added the bug Something isn't working label Sep 15, 2023
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Sep 15, 2023
@willmcgugan
Copy link
Collaborator

That may have been the original name. If you rename it to notify_style_update I think it will work.

@rodrigogiraoserrao
Copy link
Contributor Author

Yup, I figured that much. I'm just writing a decent regression test.
I'm glad I found this because it gives also some clarity on the caching issue you brought up in #3213 (comment)

rodrigogiraoserrao added a commit that referenced this issue Sep 15, 2023
@rodrigogiraoserrao
Fix #3312.
4bc7f3a
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue Sep 15, 2023
Merged
willmcgugan pushed a commit that referenced this issue Sep 20, 2023
@rodrigogiraoserrao
Fix #3312. (#3313)
732ea9d
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DataTable component styles not hot-reloading Textualize/textual
2 participants
@willmcgugan @rodrigogiraoserrao