Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxWarning for loading indicator widget #4188

Closed
charles-001 opened this issue Feb 20, 2024 · 3 comments · Fixed by #4189
Closed

SyntaxWarning for loading indicator widget #4188

charles-001 opened this issue Feb 20, 2024 · 3 comments · Fixed by #4189
Assignees
Labels
bug Something isn't working Task

Comments

@charles-001
Copy link

I receive this warning after upgrading to 0.52.0:

/Users/cthompson/Library/Caches/pypoetry/virtualenvs/dolphie-z84eXs3q-py3.11/lib/python3.11/site-packages/textual/widgets/_loading_indicator.py:57: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if self.app.animation_level is "none":

https://github.com/Textualize/textual/blob/main/src/textual/widgets/_loading_indicator.py#L57

Seems we just need to change is "none" to == "none"

@Textualize Textualize deleted a comment from github-actions bot Feb 20, 2024
@davep davep added bug Something isn't working Task labels Feb 20, 2024
@willmcgugan
Copy link
Collaborator

Let's fix this and get a patch release out today

@davep davep self-assigned this Feb 20, 2024
@davep
Copy link
Contributor

davep commented Feb 20, 2024

On it.

Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants