Add get_child_by_id and get_widget_by_id #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
darrenburns
commented
Nov 9, 2022
•
darrenburns
commented
- Maintains dict of ID -> Widget inside the NodeList for quick access children by ID
- Removes DOMNode.get_child
- Removes App.get_child
- Adds Widget.get_child_by_id
- Adds App.get_child_by_id (delegates to self.screen.get_child_by_id)
- Adds Widget.get_widget_by_id
- Adds App.get_widget_by_id (delegates to self.screen.get_widget_by_id)
willmcgugan
requested changes
Nov 9, 2022
willmcgugan
requested changes
Nov 10, 2022
|
@darrenburns Could you do a quick pass on this one next change you get. |
willmcgugan
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.