Ensure pretty traceback for error in Widget compose method #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of interest, where was that exception going previously? |
willmcgugan
approved these changes
Jan 6, 2023
|
@willmcgugan It was difficult to follow and I only looked briefly but it looked like it was just unhandled - going back up to process_messages. |
rodrigogiraoserrao
pushed a commit
that referenced
this pull request
Jan 7, 2023
* Ensure pretty traceback for error in Widget compose method * Fail fast and pretty tracebacks for Widget compose errors
nitzan-shaked
pushed a commit
to nitzan-shaked/textual
that referenced
this pull request
Jan 10, 2023
…e#1505) * Ensure pretty traceback for error in Widget compose method * Fail fast and pretty tracebacks for Widget compose errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now fails immediately and displays a Rich traceback.
Previously it still rendered (although incorrectly) and then displayed a plain traceback on app exit.
Please review the following checklist.