Allow numbers in descendant-combined type selectors (fix #1836) #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A reasonable test might be to have some CSS that we know should parse, and see if it parses without errors. |
@willmcgugan Is there a spot in the tests for that sort of thing right now? I went looking, wanting to fit this in, but couldn't obviously see anything. If not I'll kick some testing off based around this. |
|
Don't believe so. Worth adding I think. Just one big string with known rules and edge cases. |
|
Cool. Sounds worthwhile. Will do. |
|
Actually, on second look, it looks like |
rodrigogiraoserrao
approved these changes
Feb 20, 2023
willmcgugan
approved these changes
Feb 20, 2023
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1836; it'll also help folk style a
Markdownwith a bit more specificity too.NOTE: Looks like we may need some tests around this sort of thing; I would have added one for this problem as part of this PR but it wasn't clear to me where in the tests it should go, or indeed if we have any around this right now. We may want to review this as part of this or as a followup.