Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading indicator simplify #2050

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Loading indicator simplify #2050

merged 4 commits into from
Mar 14, 2023

Conversation

willmcgugan
Copy link
Collaborator

Simplify loading indicator

davep
davep approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought about the documentation for this, otherwise all good.

@willmcgugan willmcgugan merged commit c5f1cbd into main Mar 14, 2023
@willmcgugan willmcgugan deleted the loading-indicator-simplify branch March 14, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep davep approved these changes

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmcgugan @davep