Allow paths when creating 'DirectoryTree'. #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issues: #1438.
rodrigogiraoserrao
requested review from
willmcgugan and
davep
and removed request for
willmcgugan
willmcgugan
reviewed
Mar 21, 2023
willmcgugan
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #1438.
This felt like a no-brainer given that we can support
pathlib.Path(which makes a lot of sense) without needing to modify the inner workings by letting everything stay a string.It would've taken longer to ask if it made sense to implement this than to just wait for this PR to get accepted/closed.