Expanding fr #2221
Merged
Expanding fr #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def is_relative_height(self) -> bool: | ||
| """Does the node have a relative width?""" | ||
| height = self.height | ||
| return height is not None and height.unit in (Unit.FRACTION, Unit.PERCENT) |
There was a problem hiding this comment.
Aren't w, h, vh, and vw, relative units too?
There was a problem hiding this comment.
w and h become percent units.
vh and vw aren't relative to the container, unless the container happens to be screen. Maybe the name could be clarified?
There was a problem hiding this comment.
A clarification is always welcome, in my opinion.
davep
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand "auto" container if any child has a relative dimension (
fror%).Fix margins not being respected when containers have auto dimensions.
Fixes #2220