Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RadioSet redux #2372

Merged
merged 10 commits into from
Apr 25, 2023
Merged

RadioSet redux #2372

merged 10 commits into from
Apr 25, 2023

Commits on Apr 25, 2023

  1. Highlight a RadioSet when focus is within it

    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    b36afd8 View commit details
    Browse the repository at this point in the history

  2. Turn a RadioSet into a single focus switching site 

    With this commit a RadioSet becomes something you can tab into and out of
with just one keypress; navigation of the buttons within moves to being done
with the cursor keys instead.

See Textualize#2368.
    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    59506f3 View commit details
    Browse the repository at this point in the history

  3. Update the snapshot tests 

    This is necessary now that a focused RadioSet has acquired a border colour
similar to that if a focused Input.
    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    e16493b View commit details
    Browse the repository at this point in the history

  4. Add some unit testing of the new navigation

    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a6a3731 View commit details
    Browse the repository at this point in the history

  5. Change RadioSet so it's less a container of widgets and more a widget 

    Initially we went with a RadioSet being a simple container of RadioButtons,
with the user navigating the RadioButtons like you would any other set of
widgets. This was fine but it became pretty clear pretty quickly that having
to tab through a non-trivial collection of buttons in a set to get to the
next widget wasn't ideal.

This commit, satisfying Textualize#2368, takes over the navigation of the buttons
within the container, makes the container itself a focusable widget, and
sets up some new bindings to allow a more natural and efficient interaction
with the set.
    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    c45f935 View commit details
    Browse the repository at this point in the history

  6. Update the CHANGELOG

    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    0d5db58 View commit details
    Browse the repository at this point in the history

  7. Link the RadioSet CHANGELOG entry to the new PR

    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f2c56e7 View commit details
    Browse the repository at this point in the history

  8. Force a wee wait when testing the demo 

    This keeps randomly failing in Windows in CI; multiple subsequent runs gets
it going in the end, normally one further fail at a time. So let's throw a
wee wait on the end and see if that helps.
    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    88926a4 View commit details
    Browse the repository at this point in the history

  9. Lower the wait for the demo snapshot test 

    250 worked; so let's try it lower.
    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    db45287 View commit details
    Browse the repository at this point in the history

  10. Demo snapshot test back up to a 250 wait 

    Waiting 100 resulted in a fail, so let's bump back up again.
    @davep
    davep committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    7a536c7 View commit details
    Browse the repository at this point in the history