Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On decorator #2453

Merged
merged 16 commits into from
May 2, 2023
Merged

On decorator #2453

merged 16 commits into from
May 2, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented May 2, 2023 •
edited
Loading

Implement the @on decorator

Fixes #2398

@willmcgugan willmcgugan marked this pull request as draft May 2, 2023 13:21
@willmcgugan willmcgugan marked this pull request as ready for review May 2, 2023 13:23
@willmcgugan willmcgugan mentioned this pull request May 2, 2023
Closed
davep
davep approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typo things and an extreme test suggestion but otherwise looking good! Looking forward to using this.

docs/guide/events.md Outdated Show resolved Hide resolved
docs/guide/events.md Outdated Show resolved Hide resolved
tests/test_on.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be tempted to add a test here that MyApp.my_custom_handler.__doc__ is what is expected, but that might be taking things too far.

willmcgugan and others added 2 commits May 2, 2023 15:18
@willmcgugan @davep
Update docs/guide/events.md
1e05ee4 
Co-authored-by: Dave Pearson <davep@davep.org>
@willmcgugan @davep
Update docs/guide/events.md
ad0e62c 
Co-authored-by: Dave Pearson <davep@davep.org>
rodrigogiraoserrao
rodrigogiraoserrao approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions.

docs/examples/events/on_decorator.css Outdated Show resolved Hide resolved
docs/guide/events.md Outdated Show resolved Hide resolved
docs/guide/events.md Outdated Show resolved Hide resolved
docs/guide/events.md Show resolved Hide resolved
src/textual/_on.py Outdated Show resolved Hide resolved
src/textual/_on.py Outdated Show resolved Hide resolved
willmcgugan and others added 6 commits May 2, 2023 15:40
@willmcgugan @rodrigogiraoserrao
Update docs/examples/events/on_decorator.css
0a6d127 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
@willmcgugan @rodrigogiraoserrao
Update docs/guide/events.md
a0584f0 
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
@willmcgugan
rewording
d3255e6
@willmcgugan
comment
402f35f
@willmcgugan
clarification
288023d
@willmcgugan
Added note
07352a6
@willmcgugan willmcgugan merged commit 91a9d57 into main May 2, 2023
@willmcgugan willmcgugan deleted the on-decorator branch May 2, 2023 15:17
@davep davep mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep davep approved these changes

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decorator approach to event handling
3 participants
@willmcgugan @davep @rodrigogiraoserrao