Option to ensure scroll_to_center doesn't scroll so as to hide the top left corner of the widget #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
approved these changes
May 29, 2023
willmcgugan
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how feasible it is to test this right now given the other
scroll_to_centertest is XFAIL pending a compositor bug fix.Here's a video of the new behaviour. Notice that when we tab to the larger widgets, it doesn't scroll to the center of them. The top left of the widget remains in view. Previously, when we tabbed to them, the top of the widget was not visible.
scroll-center-change-29may23.mov