In devtools show confirmation of successfully loading CSS after a previous fail #2716
Conversation
| if self._css_has_errors: | ||
| from rich.panel import Panel | ||
|
|
||
| self.log.system( | ||
| Panel( | ||
| "CSS files successfully loaded after previous error:\n\n- " | ||
| + "\n- ".join(str(path) for path in css_paths), | ||
| style="green", | ||
| border_style="green", | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Shouldn't this be in the else statement already?
There was a problem hiding this comment.
Already? Not sure I follow. This is something new. Extra bit of logging to go with the existing logging.
There was a problem hiding this comment.
Ignore the "already", then.
Shouldn't this be the first piece of code in the else instead of the last piece of code in the try?
There was a problem hiding this comment.
Ahh I see. That would work too, but I was keeping the logging with the existing logging.
There was a problem hiding this comment.
Maybe both logs should be in the else statement. 🤷
There was a problem hiding this comment.
That would work too, of course, but I feel keeping the reporting of the elapsed time closer to the calculation of it makes for an easier read.
See #2534