Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style review #2777

Merged
merged 9 commits into from
Jun 14, 2023
Merged

Style review #2777

merged 9 commits into from
Jun 14, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Jun 14, 2023

This is an attempt to harmonize our widgets, form widgets in particular. Consider this a first pass, there is still work to be done.

I almost replaced the "3D" buttons with flat buttons, but I'm not quite ready to give them up.
Screenshot 2023-06-14 at 10 56 42

Screenshot 2023-06-14 at 10 56 46

@willmcgugan willmcgugan marked this pull request as draft June 14, 2023 09:49
@willmcgugan willmcgugan changed the title WIP Style review Style review Jun 14, 2023
@willmcgugan willmcgugan marked this pull request as ready for review June 14, 2023 10:03
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a huge "BREAKING CHANGE" entry in the ChangeLog, otherwise looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants