Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clear_options() for SelectionList #3075

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Fix clear_options() for SelectionList #3075

merged 4 commits into from
Aug 9, 2023

Conversation

nmay231
Copy link
Contributor

@nmay231 nmay231 commented Aug 8, 2023 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@nmay231 nmay231 force-pushed the fix-selection-clear-options branch from 36ff32b to 8bf2d80 Compare August 8, 2023 21:18
@davep davep added the bug Something isn't working label Aug 9, 2023
davep
davep approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Thanks for that.

@davep davep merged commit 3fa6f7b into Textualize:main Aug 9, 2023
19 checks passed
@nmay231 nmay231 deleted the fix-selection-clear-options branch August 9, 2023 07:24
@nmay231
Copy link
Contributor Author

nmay231 commented Aug 10, 2023

It was less like something that I spotted and more like a pin that I sat on 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep davep approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmay231 @davep