Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let layers be strings. #3169

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Let layers be strings. #3169

merged 4 commits into from
Aug 28, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

Motivated by syntax highlighting of TCSS, I'd like us to consider allowing the values of layer and layers be strings.
I.e., allow CSS like this:

Screen {
    layers: "layer-name";
}

#widget {
    layer: "layer-name";
}

Nothing needs to be done for layer because it doesn't check its token type.
For layers, the change is trivial and can be seen in this PR.

@rodrigogiraoserrao rodrigogiraoserrao added the question Further information is requested label Aug 24, 2023
@willmcgugan
Copy link
Collaborator

Seems reasonable. Could you add a changelog entry?

@rodrigogiraoserrao
Copy link
Contributor Author

Seems reasonable.

Just to confirm: seems reasonable that we accept strings and push it as the "standard" or just that we have this possibility?

@willmcgugan
Copy link
Collaborator

I think strings are only necessary if you want additional characters or spaces in your layer names. I wouldn't say it should be the standard exactly, just an alternative.

@rodrigogiraoserrao
Copy link
Contributor Author

I think strings are only necessary if you want additional characters or spaces in your layer names. I wouldn't say it should be the standard exactly, just an alternative.

Understood.

Feel free to review to approve/reject.

@willmcgugan willmcgugan merged commit a50d27f into main Aug 28, 2023
19 checks passed
@willmcgugan willmcgugan deleted the layers-can-be-strings branch August 28, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants