Fix IME pop-up issues #3408
Merged
Fix IME pop-up issues #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
requested review from
willmcgugan,
rodrigogiraoserrao and
davep
and removed request for
willmcgugan and
rodrigogiraoserrao
rodrigogiraoserrao
approved these changes
Oct 4, 2023
willmcgugan
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with the IME popups and emoji popups (fixes #1469, fixes #3404).
Adds
cursor_positionattribute toApp, which widgets can set in order to inform Textual where the terminal cursor should be moved in screen-space. This is important because the location of the terminal cursor determines where the emoji and IME popups appear when typing in widgets that support text input.InputTextAreaExamples:
Inputwidget IMETextAreawidget IMEEmoji popup
Please review the following checklist.