Add default syntax mapping to CSS theme in TextArea #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
commented
Feb 11, 2024
| @@ -1032,6 +1017,21 @@ def render_line(self, widget_y: int) -> Strip: | |||
| else: | |||
| line.stylize(selection_style, end=line_character_count) | |||
|
|
|||
| highlights = self._highlights | |||
There was a problem hiding this comment.
Just reordering the style sandwich ingredients here, no actual change to the code that is inside the diff.
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies the syntax highlighting from the dark VSCode theme in to the default CSS theme.
So now, if you set the
languageparameter on the plainTextArea(not usingcode_editor), you'll get some highlighting:Previously, since there was no syntax highlighting style mapping, tree-sitter was parsing the file but there was no visual indication of that.
This was created with
TextArea(text=TEXT, language="markdown")(and line numbers enabled).