Grid gutter fix #4219
Merged
Grid gutter fix #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
force-pushed
the
grid-gutter-fix
branch
from
1fa40da
to
f2ff9ca
Compare
rodrigogiraoserrao
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Looks good to me.
With a terminal width of 81 or 82 characters, the app I introduced as a snapshot test would break in the same way as the app of the OP in the original issue.
(There would be a tall green region between two consecutive rows of the grid.)
With the fix, the gap between rows matches the grid gutter specified.
|
Sweet. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for grid gutter issue.