-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix select #4499
Fix select #4499
Conversation
@TomJGooding I think this is the fix... |
Wouldn't this introduce a new issue where the select-expanded.mp4 |
You're absolutely right. Pushed an alternative fix, which doesn't break hiding the drop down on blur. |
This seems to have done the trick from a quick test! Just for my own knowledge, is this suppression of the click really only required because the 'overlay' concept doesn't play nicely with how the focus is handled? |
Pretty much. The interaction with click / blur was proving to be difficult to unpick. I suspect it could be done much simpler with pure CSS, but I didn't get that far. |
Fixes #4489