Don't sort "discover" items in the command palette #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hope you don't mind me sticking my nose in, but the docs should also be updated here: textual/docs/guide/command_palette.md Line 116 in 2abe889 |
|
Cheers @TomJGooding - I've removed that line now! |
willmcgugan
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's reasonable to give the user control over the order of items displayed in the command palette when it's first opened (I want to group related commands).
If they want to sort, they can easily call
sortedthemselves.Closes #4705 (fixes the final bullet point - the other problems are already resolved as of
0.72.0)