Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable performance improvements #4748

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Conversation

darrenburns
Copy link
Member

Massively improves performance when cells contain multi-line content.

Fixes #4737 (also halves the startup time of that app!)

@darrenburns darrenburns marked this pull request as ready for review July 15, 2024 14:11
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just a pedantic request.

src/textual/widgets/_data_table.py Outdated Show resolved Hide resolved
@darrenburns darrenburns merged commit 74bc89c into main Jul 15, 2024
20 checks passed
@darrenburns darrenburns deleted the datatable-perf-improvements branch July 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable: Switching focus is slow when table contains lots of data
2 participants