Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tree.move_cursor, and ensure Tree.select_node selects the node #4753

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Add Tree.move_cursor, and ensure Tree.select_node selects the node #4753

merged 8 commits into from
Jul 15, 2024

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Jul 15, 2024 •
edited
Loading

Fixes #4660

Tidies up the messages in Tree.

  • Node.Selected is now sent before Node.Expanded
  • Tree.move_cursor added - which just moves the cursor without selecting.
  • Tree.select_node updated to move the cursor to a node and then select it.

@darrenburns darrenburns marked this pull request as ready for review July 15, 2024 15:33
@darrenburns darrenburns mentioned this pull request Jul 15, 2024
Closed
@darrenburns darrenburns merged commit 53adedf into main Jul 15, 2024
18 of 19 checks passed
@darrenburns darrenburns deleted the tree-select-node-change branch July 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree.select_node doesn't select the node, it highlights it
2 participants
@darrenburns @willmcgugan