Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow login via username #677

Closed
nikkothari22 opened this issue Feb 15, 2024 · 4 comments
Closed

Allow login via username #677

nikkothari22 opened this issue Feb 15, 2024 · 4 comments
Assignees
@prathameshkurunkar7
Labels
easy Task is relatively easy to perform 💻 webapp

Comments

@nikkothari22
Copy link
Member

We only allow login via email address right now. We should remove the validation and allow login via username as well.
@nikkothari22 nikkothari22 added 💻 webapp easy Task is relatively easy to perform 📱 mobile app labels Feb 15, 2024
@linear Linear
Copy link

linear bot commented Feb 15, 2024

RAV-72 Allow login via username

@prathameshkurunkar7
Copy link
Member

frappe doesn't allow login via username, hence this cannot be implemented as of now.

@NagariaHussain
Copy link
Collaborator

frappe doesn't allow login via username

It does allow username login 🤔

@prathameshkurunkar7
Copy link
Member

If allow_login_using_user_name is set in System settings, then we can use username while finding the user, reopening and fixing this issue.

prathameshkurunkar7 added a commit that referenced this issue Feb 19, 2024
@prathameshkurunkar7
RAV-72 Allow login via username [#677]
486b9cc
prathameshkurunkar7 added a commit that referenced this issue Feb 19, 2024
@prathameshkurunkar7
RAV-72 Allow login via username [#677]
6d9419b
@linear linear bot closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prathameshkurunkar7 prathameshkurunkar7

Labels
easy Task is relatively easy to perform 💻 webapp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikkothari22 @NagariaHussain @prathameshkurunkar7