Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate dumpster fix #1094

Closed
wants to merge 1 commit into from

Conversation

blaggacao
Copy link
Contributor

No description provided.

@nikkothari22
Copy link
Member

@blaggacao I think the latest version of Frappe (develop) doesn't throw any error, but now it's not detecting our existing tests.

image
raven-bench % bench --verbose run-tests --app raven
Starting test run with parameters: site=raven-index.test, app=raven, verbose=True, tests=(), force=False, profile=False, failfast=False, skip_before_tests=False, selected_categories=[]
Detailed logs: /Users/nikhil/Desktop/raven-bench/logs/frappe.testing.log

Test Results:

All tests passed successfully!

We have some tests written in test_chat_stream.py that used to work but are not detected anymore.

@blaggacao
Copy link
Contributor Author

@nikkothari22 Sounds like a bug, let me check.

@blaggacao blaggacao force-pushed the ci/test-fix branch 2 times, most recently from 524ce67 to b307040 Compare November 5, 2024 13:04
@blaggacao blaggacao closed this Nov 5, 2024
@blaggacao blaggacao deleted the ci/test-fix branch November 5, 2024 13:50
@blaggacao
Copy link
Contributor Author

Fixed via frappe/frappe#28367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants