Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: mypy ci #26

Merged
merged 13 commits into from
Jul 11, 2024
Merged

Feat: mypy ci #26

merged 13 commits into from
Jul 11, 2024

Conversation

luarss
Copy link
Collaborator

@luarss luarss commented Jul 4, 2024 •
edited
Loading

Fixes mypy CI for frontend and backend.

Fixes #16

@luarss luarss requested a review from dralabeing July 6, 2024 10:24
@luarss luarss marked this pull request as ready for review July 6, 2024 10:40
@dralabeing dralabeing requested review from vvbandeira and removed request for vvbandeira July 6, 2024 17:42
vvbandeira
vvbandeira reviewed Jul 8, 2024
View reviewed changes
.github/workflows/mypy.yaml Outdated Show resolved Hide resolved
.github/workflows/mypy.yaml Outdated Show resolved Hide resolved
@luarss luarss requested a review from vvbandeira July 9, 2024 03:19
luarss
luarss commented Jul 9, 2024
View reviewed changes
frontend/requirements-test.txt Outdated Show resolved Hide resolved
luarss
luarss commented Jul 9, 2024
View reviewed changes
frontend/requirements.txt Outdated Show resolved Hide resolved
luarss
luarss commented Jul 9, 2024
View reviewed changes
.github/workflows/mypy.yaml Outdated Show resolved Hide resolved
vvbandeira
vvbandeira previously approved these changes Jul 9, 2024
View reviewed changes
@vvbandeira
Copy link
Member

@luarss
This has conflicts due to the other PR merge.

luarss and others added 7 commits July 10, 2024 01:28
@luarss
add ci
4378665 
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss
fix
798b12f 
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss
update ci
c5d5b45 
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss
fix mypy
c747b0b 
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss
fix frontend mypy
448b699 
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss
Update mypy.yaml
abc09bf 
Signed-off-by: Song Luar <luar.shuisong@gmail.com>
@luarss
chore: update dependencies and CI configuration
c34365e 
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss
chore: update service account file path and variable names
d3fbef0 
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss luarss requested a review from vvbandeira July 10, 2024 01:37
luarss added 3 commits July 10, 2024 20:46
@luarss
Merge branch 'master' into feat/mypy-ci
c307c83 
Signed-off-by: Song Luar <espsluar@gmail.com>
@luarss
Update requirements.txt
b0270e4 
Signed-off-by: Song Luar <espsluar@gmail.com>
@luarss
Update requirements-test.txt
9bba629 
Signed-off-by: Song Luar <espsluar@gmail.com>
vvbandeira
vvbandeira previously approved these changes Jul 10, 2024
View reviewed changes
@luarss
Update requirements.txt
d837ee0 
Signed-off-by: Song Luar <espsluar@gmail.com>
@luarss
Update requirements-test.txt
48a82e0 
Signed-off-by: Song Luar <espsluar@gmail.com>
@luarss luarss requested a review from vvbandeira July 10, 2024 13:25
@luarss luarss merged commit 0b80442 into The-OpenROAD-Project:master Jul 11, 2024
5 checks passed
@luarss luarss deleted the feat/mypy-ci branch July 11, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvbandeira vvbandeira vvbandeira approved these changes

@dralabeing dralabeing Awaiting requested review from dralabeing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy CI
2 participants
@luarss @vvbandeira