Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add well-formed parentheses generator #2445

Merged
merged 19 commits into from
May 16, 2023
Merged

feat: add well-formed parentheses generator #2445

merged 19 commits into from
May 16, 2023

Conversation

giuseppe-coco
Copy link
Contributor

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label Apr 12, 2023
Panquesito7
Panquesito7 requested changes Apr 12, 2023
View reviewed changes
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Show resolved Hide resolved
backtracking/generate_parentheses.cpp Show resolved Hide resolved
backtracking/generate_parentheses.cpp Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 requested changes Apr 14, 2023
View reviewed changes
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
giuseppe-coco and others added 2 commits April 15, 2023 10:58
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
e9bc5dc 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
46c4cc1 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 requested changes Apr 17, 2023
View reviewed changes
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Show resolved Hide resolved
giuseppe-coco and others added 2 commits April 26, 2023 18:36
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
efca21d 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
9109ced 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 requested changes Apr 26, 2023
View reviewed changes
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
giuseppe-coco and others added 7 commits April 26, 2023 19:35
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
6f790f3 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
a8209d2 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
5029e71 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
e1fafd0 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
3264a41 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
352cf4d 
Co-authored-by: David Leal <halfpacho@gmail.com>
@giuseppe-coco @Panquesito7
Update backtracking/generate_parentheses.cpp
18a0851 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Thanks! 🚀

realstealthninja
realstealthninja previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just would love to hear your thoughts on one of the doc strings. Thank you for contributing! 🙂

backtracking/generate_parentheses.cpp Outdated Show resolved Hide resolved
@giuseppe-coco @realstealthninja
Update backtracking/generate_parentheses.cpp
728ddde 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
realstealthninja
realstealthninja previously approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

Panquesito7
Panquesito7 previously approved these changes Apr 27, 2023
View reviewed changes
@Panquesito7 Panquesito7 requested a review from tjgurwara99 April 27, 2023 17:35
tjgurwara99
tjgurwara99 previously approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@tjgurwara99 tjgurwara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I don't mind this approach but this problem is well suited for a function based approach, I'm not sure why you went with object oriented approach (unless leetcode scaffold was specific to that, in which case its fine)

backtracking/generate_parentheses.cpp Show resolved Hide resolved
@giuseppe-coco
Copy link
Contributor Author

What is missing to merge PR?

@realstealthninja
Copy link
Collaborator

realstealthninja commented May 2, 2023 •
edited
Loading

Just update the branch; there is a button below the unable to merge pull request to update the branch click that and wait for one of the maintainers to merge

@giuseppe-coco
Copy link
Contributor Author

Ok thanks.

@Panquesito7 Panquesito7 merged commit 6027480 into TheAlgorithms:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja left review comments

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giuseppe-coco @realstealthninja @tjgurwara99 @Panquesito7