Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory issues in counting_sort.cpp #2533

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 11, 2023

Description of Change

There are several problems with the current implementation of counting_sort.cpp:

This PR fixes that.

Checklist

  • Added description of change
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
This PR fixes memory issues in counting_sort.cpp.

@vil02 vil02 marked this pull request as ready for review September 11, 2023 17:39
@vil02 vil02 changed the title fix: _memory issues_ in counting_sort.cpp fix: memory issues in counting_sort.cpp Sep 11, 2023
Copy link
Member

@CarlosZoft CarlosZoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@vil02 vil02 force-pushed the memory_issues_in_counting_sort_patch branch from 62c5413 to 2c7874b Compare October 2, 2023 11:49
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Dec 25, 2023
@vil02
Copy link
Member Author

vil02 commented Dec 25, 2023

@Panquesito7, @realstealthninja: please dont-close.

@github-actions github-actions bot removed the stale Author has not responded to the comments for over 2 weeks label Dec 26, 2023
@realstealthninja realstealthninja added the dont-close This issue/pull request shouldn't be closed label Jan 5, 2024
@vil02 vil02 force-pushed the memory_issues_in_counting_sort_patch branch from 2c7874b to 1f7fb02 Compare January 16, 2024 07:13
@vil02 vil02 force-pushed the memory_issues_in_counting_sort_patch branch from 1f7fb02 to 9c29933 Compare February 12, 2024 21:16
@realstealthninja realstealthninja merged commit 519d37f into TheAlgorithms:master Aug 30, 2024
7 checks passed
@vil02 vil02 deleted the memory_issues_in_counting_sort_patch branch August 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-close This issue/pull request shouldn't be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants