-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memory issues in counting_sort.cpp
#2533
Merged
realstealthninja
merged 4 commits into
TheAlgorithms:master
from
vil02:memory_issues_in_counting_sort_patch
Aug 30, 2024
Merged
fix: memory issues in counting_sort.cpp
#2533
realstealthninja
merged 4 commits into
TheAlgorithms:master
from
vil02:memory_issues_in_counting_sort_patch
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
requested review from
Panquesito7 and
realstealthninja
as code owners
September 11, 2023 17:39
vil02
changed the title
fix: _memory issues_ in
fix: memory issues in Sep 11, 2023
counting_sort.cpp
counting_sort.cpp
CarlosZoft
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
vil02
force-pushed
the
memory_issues_in_counting_sort_patch
branch
from
October 2, 2023 11:49
62c5413
to
2c7874b
Compare
realstealthninja
approved these changes
Nov 15, 2023
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Author has not responded to the comments for over 2 weeks
label
Dec 25, 2023
@Panquesito7, @realstealthninja: please |
github-actions
bot
removed
the
stale
Author has not responded to the comments for over 2 weeks
label
Dec 26, 2023
vil02
force-pushed
the
memory_issues_in_counting_sort_patch
branch
from
January 16, 2024 07:13
2c7874b
to
1f7fb02
Compare
vil02
force-pushed
the
memory_issues_in_counting_sort_patch
branch
from
February 12, 2024 21:16
1f7fb02
to
9c29933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There are several problems with the current implementation of
counting_sort.cpp
:*Count
is uninitialized and not deleted,C-Plus-Plus/sorting/counting_sort.cpp
Line 29 in 23b133a
*Sorted_Arr
is not deleted.C-Plus-Plus/sorting/counting_sort.cpp
Line 27 in 23b133a
This PR fixes that.
Checklist
Notes:
This PR fixes memory issues in
counting_sort.cpp
.