Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Trapped RainWater #2716

Merged
merged 11 commits into from
Aug 31, 2024

Conversation

sozelfist
Copy link
Contributor

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@sozelfist
Copy link
Contributor Author

BTW, Could you have a look on this PR, @realstealthninja.

dynamic_programming/trapped_rainwater.cpp Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
@realstealthninja realstealthninja added enhancement New feature or request awaiting modification Do not merge until modifications are made labels Aug 31, 2024
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use fixed-width integer typedefs instead of type modifiers.
this is so that the integers are actually the specified length
instead of compiler/platform dependent

further reading

dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
@realstealthninja realstealthninja merged commit 9702903 into TheAlgorithms:master Aug 31, 2024
7 checks passed
@sozelfist sozelfist deleted the dp/trapped_rainwater branch August 31, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting modification Do not merge until modifications are made enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants