-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Trapped RainWater #2716
Merged
realstealthninja
merged 11 commits into
TheAlgorithms:master
from
sozelfist:dp/trapped_rainwater
Aug 31, 2024
Merged
Implement Trapped RainWater #2716
realstealthninja
merged 11 commits into
TheAlgorithms:master
from
sozelfist:dp/trapped_rainwater
Aug 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sozelfist
requested review from
Panquesito7 and
realstealthninja
as code owners
August 31, 2024 02:45
BTW, Could you have a look on this PR, @realstealthninja. |
realstealthninja
requested changes
Aug 31, 2024
realstealthninja
added
enhancement
New feature or request
awaiting modification
Do not merge until modifications are made
labels
Aug 31, 2024
realstealthninja
requested changes
Aug 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always use fixed-width integer typedefs instead of type modifiers.
this is so that the integers are actually the specified length
instead of compiler/platform dependent
further reading
realstealthninja
previously approved these changes
Aug 31, 2024
realstealthninja
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Checklist
Notes: