Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix : Approved label CI does not add approved label to pull requests. #2732

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sonavalepratham
Copy link

@sonavalepratham sonavalepratham commented Sep 13, 2024

Description of Change

Fixes #2719

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
bug fix : Approved label CI does not add approved label to pull requests.

@sonavalepratham sonavalepratham force-pushed the dev/ps_ISSUE-2719 branch 2 times, most recently from 1477ebd to 5891e94 Compare September 14, 2024 06:14
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this works

.github/workflows/approved-label.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work. Please check this in your fork

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 2

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope does not work.

@sonavalepratham sonavalepratham marked this pull request as draft September 15, 2024 19:49
@sonavalepratham sonavalepratham force-pushed the dev/ps_ISSUE-2719 branch 2 times, most recently from 7883c67 to 0925f4e Compare September 15, 2024 20:33
@sonavalepratham sonavalepratham marked this pull request as ready for review September 15, 2024 20:45
@sonavalepratham
Copy link
Author

fixed typo, please check if it works if not, I will try with actions-ecosystem/action-add-labels

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test2

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work

1/1 approvals
Labeling pull request
{
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/issues/labels#add-labels-to-an-issue",
  "status": "403"
}

This is the error it's trying to add the label to an issue so maybe check this action's documention

@sonavalepratham
Copy link
Author

image

why it's showing read permission to pull requests? in my fork showing write permission
in repository Settings -> Actions -> General correct permission is given?

@realstealthninja
Copy link
Collaborator

image

why it's showing read permission to pull requests? in my fork showing write permission in repository Settings -> Actions -> General correct permission is given?

@Panquesito7 could you enable the setting in this repo?
https://stackoverflow.com/questions/72376229/github-actions-is-not-permitted-to-create-or-approve-pull-requests-createpullre

@realstealthninja realstealthninja added testing automated tests are failing Do not merge until tests pass dont-close This issue/pull request shouldn't be closed labels Oct 4, 2024
@realstealthninja realstealthninja removed the automated tests are failing Do not merge until tests pass label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-close This issue/pull request shouldn't be closed testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Approved label CI does not add approved label to pull requests.
2 participants