Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longest Increasing subsequence using binary search most optimal approach (Modified) #2776

Merged
merged 25 commits into from
Oct 18, 2024
Merged

Longest Increasing subsequence using binary search most optimal approach (Modified) #2776

merged 25 commits into from
Oct 18, 2024

Conversation

namanmodi65
Copy link
Contributor

@namanmodi65 namanmodi65 commented Oct 6, 2024 •
edited
Loading

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

realstealthninja
realstealthninja requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the format of the header comment used in the contributing.md file

@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Oct 7, 2024
@namanmodi65
Copy link
Contributor Author

I did not get what you are trying to say can you please elaborate

@realstealthninja
Copy link
Collaborator

I did not get what you are trying to say can you please elaborate

please read the following file and format your code accordingly
https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#Commit-Guidelines

@namanmodi65
Copy link
Contributor Author

changes are done!

@realstealthninja
Copy link
Collaborator

is this for hacktoberfest?

@namanmodi65
Copy link
Contributor Author

Yes this is for hacktoberfest

@namanmodi65 namanmodi65 closed this Oct 8, 2024
@namanmodi65 namanmodi65 reopened this Oct 8, 2024
@realstealthninja
Copy link
Collaborator

Why is the pull request called longest increasing sequence but it is an implementation of floyd warshall?

@namanmodi65
Copy link
Contributor Author

Why is the pull request called longest increasing sequence but it is an implementation of floyd warshall?

now its correct

@namanmodi65
Copy link
Contributor Author

namanmodi65 commented Oct 10, 2024 •
edited
Loading

Why is the pull request called longest increasing sequence but it is an implementation of floyd warshall?

By mistake i have pushed the floyd warshall code with longest increasing sequence now i have removed that code.
Please ignore the Floyd warshall commit

realstealthninja
realstealthninja requested changes Oct 11, 2024
View reviewed changes
graph/.vscode/settings.json Outdated Show resolved Hide resolved
graph/floyd_warshall.cpp Outdated Show resolved Hide resolved
search/Longest_Increasing_Subsequence_using_binary_search.cpp Outdated Show resolved Hide resolved
search/Longest_Increasing_Subsequence_using_binary_search.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for this contribution

@realstealthninja realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed awaiting modification Do not merge until modifications are made labels Oct 12, 2024
@realstealthninja realstealthninja merged commit 05d784d into TheAlgorithms:master Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namanmodi65 @realstealthninja