-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update AVL Tree #2789
chore: Update AVL Tree #2789
Conversation
data_structures/avltree.cpp
Outdated
return 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not understand this issue... Is it resolved?
this pr should be put on hold until #2746 merges |
Is it necessary to add class names and variables in snake_case as well? |
No, the contributing.md file prefers pascal or camel case last i checked please do check and confirm |
For classes, variables, and functions, there is no explicit mention of a case preference, although the description below led me to believe that snake_case is preferred.
Also, this makes me believe that snake_case is preferred for functions
|
feel free to use snake case instead |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Description of Change
Updated AVL Tree data structure using modern C++ STL library features like
std::unique_ptr
and implemented Object Oriented structure. Also added additional tests and updated existing tests to useassert
.Checklist
Notes:
Completed the following TODO