Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Binary Addition Algorithm #2802

Merged
merged 49 commits into from
Oct 24, 2024
Merged

feat: Added Binary Addition Algorithm #2802

merged 49 commits into from
Oct 24, 2024

Conversation

mjk22071998
Copy link
Contributor

@mjk22071998 mjk22071998 commented Oct 9, 2024 •
edited
Loading

Description of Change

I have added Binary addition algorithm that takes two binary numbers as string and return a string containing a binary number equals to sum of above two numbers. This PR is under hacktoberfest

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

mjk22071998 and others added 30 commits October 5, 2024 10:13
@mjk22071998
Digit Separation Algorithm added
47af70e
@mjk22071998
Merge branch 'TheAlgorithms:master' into master
48f42a7
@mjk22071998
feat: Added namespace greedy_algoriithms
011c4e2
@mjk22071998
"Updated digit separation code: added comments and docstrings, change…
76edb15 
…d data types to std::int64_t, and reformatted code."
@mjk22071998
feat: Made test function and removed extra whitespaces
57f61a6
@mjk22071998
removed some more whitespaces
9c0034c
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
cba0eb9 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@realstealthninja
fix: terminate multiline comment
d3edb52
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
1fb86db 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
ad03474 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
5f392b9 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
373e1df 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998
Corrected test function
af077d2
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
18b6546 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Update greedy_algorithms/digit_separation.cpp
87b955b 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
remove redundant declaration
a585834 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Corrected tests
ef954a8 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998
file clang linted
1427474
@mjk22071998
Merge branch 'master' into master
a0f488b
@mjk22071998
Merge branch 'master' into master
051448f
@mjk22071998
"Moved method implementations from outside to inside class definition"
3f04892
@mjk22071998 @realstealthninja
fowardOrder to forwardOrder on line 122
ba56880 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Removed Class scope resolution form digitSeparationReverseOrder function
40ac103 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
Removed Class scope resolution form digitSeparationForwardOrderfunction
12d8d53 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998
docs: documentation updated
28f6901
@mjk22071998
Merge branch 'master' of https://github.com/mjk22071998/C-Plus-Plus
c9cd9a3
@realstealthninja
Merge branch 'master' into master
6c8305b
@realstealthninja
Merge branch 'master' into master
cffb85a
@mjk22071998
Merge branch 'TheAlgorithms:master' into master
481e5db
@mjk22071998
initial commit of Binary Addition
9772468
@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Oct 10, 2024
realstealthninja
realstealthninja requested changes Oct 12, 2024
View reviewed changes
greedy_algorithms/binary_addition.cpp Outdated Show resolved Hide resolved
greedy_algorithms/binary_addition.cpp Outdated Show resolved Hide resolved
greedy_algorithms/binary_addition.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja requested changes Oct 19, 2024
View reviewed changes
greedy_algorithms/binary_addition.cpp Outdated Show resolved Hide resolved
greedy_algorithms/binary_addition.cpp Outdated Show resolved Hide resolved
mjk22071998 and others added 3 commits October 19, 2024 16:08
@mjk22071998 @realstealthninja
Removed link
12d0b29 
Removed @see link in header documentation

Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998
Merge branch 'master' into master
cd8a595
@github-actions
clang-format and clang-tidy fixes for cd8a595
e0fc3d8
realstealthninja
realstealthninja requested changes Oct 22, 2024
View reviewed changes
greedy_algorithms/binary_addition.cpp Outdated Show resolved Hide resolved
greedy_algorithms/binary_addition.cpp Show resolved Hide resolved
greedy_algorithms/binary_addition.cpp Show resolved Hide resolved
mjk22071998 and others added 3 commits October 22, 2024 23:34
@mjk22071998 @realstealthninja
made tests() static
916ead7 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
added @returns in documentation of tests function
3f07ca4 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
@mjk22071998 @realstealthninja
added @return in documentation of main function
d039369 
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
realstealthninja
realstealthninja approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this pr

@realstealthninja realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed awaiting modification Do not merge until modifications are made labels Oct 23, 2024
@realstealthninja realstealthninja merged commit ecb8a33 into TheAlgorithms:master Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjk22071998 @realstealthninja