-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs, tests, fix: fit fibonacci_fast to contributing guidelines #2893
Conversation
Modify the fibonacci_fast.cpp to fit the project style requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Thank you very much for providing valuable suggestions. I have made an attempt to revise my PR according to your advice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done!
Thank you for your response! I noticed the following errors in Compile checks (windows-latest): |
It seems there is a new code style check that wasn’t present before. I made the necessary modifications. |
According to the check results, it seems there is still an issue with token permissions. I'm not sure if I have resolved this issue. |
Sorry for that, I'm working on finding a fix |
Looking forward to your review after you finish your work! If my PR doesn’t pass the testing, I might have to bother you again for further modifications. |
Additionally, I found that one test consistently reports an error, but I don’t know how to resolve it. If you could provide assistance, I would greatly appreciate it. https://github.com/setbit123/C-Plus-Plus/actions/runs/11996941748 |
Its just GitHub pages nothing to worry about. I'm just going to merge this |
Thank you for your reply! |
Description of Change
Modify the fibonacci_fast.cpp to fit the project style requirements.
Solve a small part of issue #2456
Checklist
Notes: