Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs, tests, fix: fit fibonacci_fast to contributing guidelines #2893

Merged
merged 12 commits into from
Nov 24, 2024

Conversation

setbit123
Copy link
Contributor

@setbit123 setbit123 commented Oct 31, 2024

Description of Change

Modify the fibonacci_fast.cpp to fit the project style requirements.
Solve a small part of issue #2456

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Sorry, something went wrong.

Modify the fibonacci_fast.cpp to fit the project style requirements.
@setbit123
Copy link
Contributor Author

cc @Panquesito7 @realstealthninja

@realstealthninja realstealthninja changed the title [Fix] Modify the fibonacci_fast.cpp to fit the project style requirements. docs, tests: fit fibonacci_fast to contributing guidelines Nov 20, 2024
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

math/fibonacci_fast.cpp Outdated Show resolved Hide resolved
math/fibonacci_fast.cpp Show resolved Hide resolved
math/fibonacci_fast.cpp Show resolved Hide resolved
@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Nov 20, 2024
@setbit123
Copy link
Contributor Author

Thank you very much for providing valuable suggestions. I have made an attempt to revise my PR according to your advice.

cc @realstealthninja

@setbit123 setbit123 changed the title docs, tests: fit fibonacci_fast to contributing guidelines docs, tests, fix: fit fibonacci_fast to contributing guidelines Nov 20, 2024
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done!

@realstealthninja realstealthninja added approved Approved; waiting for merge and removed awaiting modification Do not merge until modifications are made labels Nov 23, 2024
@setbit123
Copy link
Contributor Author

Thank you for your response! I noticed the following errors in Compile checks (windows-latest):
error C2039: 'to_string': is not a member of 'std'
error C3861: 'to_string': identifier not found
error C2512: 'std::invalid_argument': no appropriate default constructor available
I tried adding some header files to solve this issue. Looking forward to your reply!

cc @realstealthninja

realstealthninja and others added 4 commits November 24, 2024 13:15
@setbit123
Copy link
Contributor Author

It seems there is a new code style check that wasn’t present before. I made the necessary modifications.

cc @realstealthninja

@setbit123
Copy link
Contributor Author

According to the check results, it seems there is still an issue with token permissions. I'm not sure if I have resolved this issue.

cc @realstealthninja

@realstealthninja
Copy link
Collaborator

Sorry for that, I'm working on finding a fix

realstealthninja and others added 3 commits November 24, 2024 19:42
@setbit123
Copy link
Contributor Author

Looking forward to your review after you finish your work! If my PR doesn’t pass the testing, I might have to bother you again for further modifications.

cc @realstealthninja

@setbit123
Copy link
Contributor Author

Additionally, I found that one test consistently reports an error, but I don’t know how to resolve it. If you could provide assistance, I would greatly appreciate it.

https://github.com/setbit123/C-Plus-Plus/actions/runs/11996941748

cc @realstealthninja

@realstealthninja
Copy link
Collaborator

Additionally, I found that one test consistently reports an error, but I don’t know how to resolve it. If you could provide assistance, I would greatly appreciate it.

https://github.com/setbit123/C-Plus-Plus/actions/runs/11996941748

cc @realstealthninja

Its just GitHub pages nothing to worry about. I'm just going to merge this

@realstealthninja realstealthninja merged commit 77b9f39 into TheAlgorithms:master Nov 24, 2024
2 of 3 checks passed
@setbit123
Copy link
Contributor Author

Thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants