Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create longest_word_in_sentence.py #11475

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

its-100rabh
Copy link
Contributor

Describe your change:

A program to find the longest word in a sentence.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some more tests ??

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jul 7, 2024
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jul 7, 2024
@its-100rabh
Copy link
Contributor Author

its-100rabh commented Jul 7, 2024

If I add some new test cases, there is some issue with the ruff test.
The ruff/ruff (pull_request) fails for some error in the graphs directory that I have not event touched.

The failure result is:
Run ruff check --output-format=github .
ruff check --output-format=github .
shell: /usr/bin/bash -e {0}
Error: graphs/multi_heuristic_astar.py:82:12: NPY201 np.chararray will be removed in NumPy 2.0. Use numpy.char.chararray instead.
Error: Process completed with exit code 1.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jul 11, 2024
@its-100rabh its-100rabh requested a review from imSanko July 11, 2024 16:27
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good and clean.

@its-100rabh
Copy link
Contributor Author

Sounds good and clean.

Ah... Any issue that is stopping this from getting merged?

@imSanko
Copy link
Contributor

imSanko commented Aug 7, 2024

Sounds good and clean.

Ah... Any issue that is stopping this from getting merged?

Connect with [at]cclauss for getting this merged or might review it for a better.

@its-100rabh
Copy link
Contributor Author

@cclauss Can this be merged and closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants