Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctests for machine_learning/sequential_minimum_optimization.py #11571

Closed
wants to merge 13 commits into from
Closed

Add doctests for machine_learning/sequential_minimum_optimization.py #11571

wants to merge 13 commits into from

Conversation

drkrillo
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Juan Pasutti and others added 11 commits September 17, 2024 01:47
Add test for SmoSVM init attr
a6e01ce
Add doctest for _is_unbound
0f0eb95
Add doctest for _is_support
2590c34
@drkrillo
Merge pull request #1 from drkrillo/sequential_minimum_optimization_a…
2642f19 
…dd_doctests

Sequential minimum optimization add doctests
Add doctest for Kernet init func
9e1f30d
Add test to _polynomial Kernel func
8d4c9e8
Add doctest for Kernet _linear func
94b1403
@drkrillo
Merge pull request #2 from drkrillo/sequential_minimum_optimization_a…
fb58570 
…dd_doctests

Sequential minimum optimization add doctests
Add doctest to _rbf Kernel func
308fbe4
@drkrillo
Merge pull request #3 from drkrillo/sequential_minimum_optimization_a…
9d7532a 
…dd_doctests

Add doctest to _rbf Kernel func
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5f158ed 
for more information, see https://pre-commit.ci
@drkrillo drkrillo changed the title Create doctests for machine_learning/sequential_minimum_optimization.py Add doctests for machine_learning/sequential_minimum_optimization.py Sep 18, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 18, 2024
Juan Pasutti and others added 2 commits September 18, 2024 19:15
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 18, 2024
@drkrillo
Copy link
Author

drkrillo commented Oct 2, 2024 •
edited
Loading

Why am I not getting the "Awaiting review" tag?

@drkrillo drkrillo closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drkrillo