-
-
Notifications
You must be signed in to change notification settings - Fork 46k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the directory of Fractional Knapsack algorithm #7086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you update these changes in DIRECTORY.md
Hey, @CaedenPH I noticed in contributing guidelines that we do not require updating the |
Oh, I wasn't aware that there was a Github Action for this, I would assume that means you don't need to update DIRECTORY.md, however i assume that it wont make a difference now that you have updated it |
Yes. |
@cclauss Can you review? Looks good to me |
There is a git conflict below? Are the algorithms being modified or just moved? |
I have fixed the conflict, my branch was not up to date. |
Describe your change:
Fractional knapsack uses a greedy approach and, hence, comes under greedy_methods and not under dynamic_programming.
Moved the two fractional knapsack algorithm files to greedy_methods.
Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?
Checklist:
Fixes: #{$ISSUE_NO}
.