Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the directory of Fractional Knapsack algorithm #7086

Merged
merged 6 commits into from
Oct 16, 2022
Merged

Corrected the directory of Fractional Knapsack algorithm #7086

merged 6 commits into from
Oct 16, 2022

Conversation

SudhanshuSuman
Copy link
Contributor

Describe your change:

  • Fractional knapsack uses a greedy approach and, hence, comes under greedy_methods and not under dynamic_programming.

  • Moved the two fractional knapsack algorithm files to greedy_methods.

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 13, 2022
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you update these changes in DIRECTORY.md

@SudhanshuSuman
Copy link
Contributor Author

Please can you update these changes in DIRECTORY.md

Hey, @CaedenPH I noticed in contributing guidelines that we do not require updating the DIRECTORY.md file as GitHub Actions periodically autogenerates it. However, I have updated it now. Should I revert it back?

@CaedenPH
Copy link
Contributor

Please can you update these changes in DIRECTORY.md

Hey, @CaedenPH I noticed in contributing guidelines that we do not require updating the DIRECTORY.md file as GitHub Actions periodically autogenerates it. However, I have updated it now. Should I revert it back?

Oh, I wasn't aware that there was a Github Action for this, I would assume that means you don't need to update DIRECTORY.md, however i assume that it wont make a difference now that you have updated it

@SudhanshuSuman
Copy link
Contributor Author

Please can you update these changes in DIRECTORY.md

Hey, @CaedenPH I noticed in contributing guidelines that we do not require updating the DIRECTORY.md file as GitHub Actions periodically autogenerates it. However, I have updated it now. Should I revert it back?

Oh, I wasn't aware that there was a Github Action for this, I would assume that means you don't need to update DIRECTORY.md, however i assume that it wont make a difference now that you have updated it

Yes.
Can you review the pull request? It seems @Kush1101 was requested but he is not active.

@CaedenPH
Copy link
Contributor

@cclauss Can you review? Looks good to me

@cclauss
Copy link
Member

cclauss commented Oct 15, 2022

There is a git conflict below? Are the algorithms being modified or just moved?

@SudhanshuSuman
Copy link
Contributor Author

There is a git conflict below? Are the algorithms being modified or just moved?

I have fixed the conflict, my branch was not up to date.
The algorithms are just moved.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2022
@cclauss cclauss merged commit 7f6e0b6 into TheAlgorithms:master Oct 16, 2022
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants