Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to https. #7277

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Change to https. #7277

merged 2 commits into from
Oct 16, 2022

Conversation

girisagar46
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@girisagar46 girisagar46 requested a review from cclauss as a code owner October 16, 2022 04:51
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 16, 2022
cclauss
cclauss approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@cclauss cclauss merged commit e7b6d28 into TheAlgorithms:master Oct 16, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2022
@matteomessmer
Copy link
Contributor

matteomessmer commented Oct 16, 2022 •
edited by cclauss
Loading

This actually broke some of those links:

http://web.cs.iastate.edu/~honavar is not available, not even with https

@girisagar46 girisagar46 mentioned this pull request Oct 16, 2022
Merged
14 tasks
@girisagar46
Copy link
Contributor Author

This actually broke some of those links:

http://web.cs.iastate.edu/~honavar is not available, not even with https

Thank you, @matteomessmer. I've opened another PR #7319 to fix these links. I also removed this link http://web.cs.iastate.edu/~honavar in PR #7319 because I could not find any replacement.

cclauss pushed a commit that referenced this pull request Oct 16, 2022
@girisagar46
Fix broken links by PR #7277 (#7319)
b5b1eb2
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@girisagar46 @matteomessmer @cclauss