Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some print statements within algorithmic functions #7499

Merged
merged 14 commits into from
Oct 22, 2022
Merged

Remove some print statements within algorithmic functions #7499

merged 14 commits into from
Oct 22, 2022

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Oct 22, 2022 •
edited
Loading

Describe your change:

Removed some print statements within algorithmic functions (i.e., code that's not within a __main__, amain function, or a utility function).

Encapsulated some test/demo code that wasn't within __main__s.

This PR contributes to #7337 but is not a complete fix.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 22, 2022
@tianyizheng02
Copy link
Contributor Author

Somehow the build is failing with Fatal Python error: Illegal instruction when running pytest... @CaedenPH @cclauss any idea why this could be happening?

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 22, 2022
cclauss
cclauss approved these changes Oct 22, 2022
View reviewed changes
divide_and_conquer/strassen_matrix_multiplication.py Show resolved Hide resolved
dynamic_programming/subset_generation.py Outdated Show resolved Hide resolved
dynamic_programming/sum_of_subset.py Outdated Show resolved Hide resolved
machine_learning/forecasting/run.py Outdated Show resolved Hide resolved
machine_learning/forecasting/run.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 22, 2022
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 22, 2022
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 22, 2022
@cclauss cclauss merged commit cc10b20 into TheAlgorithms:master Oct 22, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 22, 2022
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 22, 2022
@cclauss cclauss mentioned this pull request Oct 22, 2022
Closed
tianyizheng02
tianyizheng02 commented Oct 22, 2022
View reviewed changes
machine_learning/forecasting/run.py

# check the safety of today's data
not_str = "" if data_safety_checker(res_vote, tst_user) else "not "
print("Today's data is {not_str}safe.")
Copy link
Contributor Author

@tianyizheng02 tianyizheng02 Oct 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss This string needs to be an f-string for not_str to print correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianyizheng02 @cclauss