Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage report tweaks #272

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

nikoyak
Copy link
Contributor

@nikoyak nikoyak commented Jun 8, 2023

Proposed Changes

This PR:

Types of changes

What types of changes does your code introduce to MiniScaffold?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Unclosed question on test coverage verification. It is not necessary to evaluate test coverage every time you run tests, and to speed up feedback, it is inconvenient to write the cmd /c "set DISABLE_COVERAGE=1& build DotnetTest" command on Windows, for example. I propose to change the logic and replacing the environment variable with ENABLE_COVERAGE. And local testing with test coverage is convenient to do with a new ShowCoverageReport target. What do you think?

@TheAngryByrd
Copy link
Owner

Unclosed question on test coverage verification. It is not necessary to evaluate test coverage every time you run tests, and to speed up feedback, it is inconvenient to write the cmd /c "set DISABLE_COVERAGE=1& build DotnetTest" command on Windows, for example. I propose to change the logic and replacing the environment variable with ENABLE_COVERAGE. And local testing with test coverage is convenient to do with a new ShowCoverageReport target. What do you think?

This is kind of tough call, some people use the coverage in their IDE to see things being covered, but coverage does slow down tests considerably. I'm leaning toward your suggestion though but I wouldn't be surprised if I get another issue down the road as to default have coverage on.

Copy link
Owner

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want me to merge this or wait for the ENABLE_COVERAGE change?

@nikoyak
Copy link
Contributor Author

nikoyak commented Jun 8, 2023

Want me to merge this or wait for the ENABLE_COVERAGE change?
Wait

@TheAngryByrd TheAngryByrd merged commit b977f61 into TheAngryByrd:master Jun 9, 2023
TheAngryByrd added a commit that referenced this pull request Jun 9, 2023
## [0.34.0] - 2023-06-09

### Changed
- [Code Coverage Tweaks](#272) from @nikoyak
@nikoyak nikoyak deleted the coverage-report-tweaks branch February 5, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants