-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage report tweaks #272
Coverage report tweaks #272
Conversation
- Added dependency on Dotnetest - Closed TheAngryByrd#251
This is kind of tough call, some people use the coverage in their IDE to see things being covered, but coverage does slow down tests considerably. I'm leaning toward your suggestion though but I wouldn't be surprised if I get another issue down the road as to default have coverage on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want me to merge this or wait for the ENABLE_COVERAGE
change?
|
Proposed Changes
This PR:
Types of changes
What types of changes does your code introduce to MiniScaffold?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Unclosed question on test coverage verification. It is not necessary to evaluate test coverage every time you run tests, and to speed up feedback, it is inconvenient to write the
cmd /c "set DISABLE_COVERAGE=1& build DotnetTest"
command on Windows, for example. I propose to change the logic and replacing the environment variable with ENABLE_COVERAGE. And local testing with test coverage is convenient to do with a new ShowCoverageReport target. What do you think?