Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #81 #86

Merged
merged 1 commit into from
May 15, 2018
Merged

Closes #81 #86

merged 1 commit into from
May 15, 2018

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented May 15, 2018

Closes #81

Proposed Changes

This implements the templating hacks in dotnet/templating#1168 (comment) to allow for dashes in names.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Why microsoft why

This implements the templating hacks in dotnet/templating#1168 (comment) to allow for dashes in names.
@TheAngryByrd TheAngryByrd merged commit 1109cf3 into master May 15, 2018
TheAngryByrd pushed a commit that referenced this pull request May 15, 2018
* BUGFIX: Fixes dotnet templating issues with dashes (#86)
TheAngryByrd pushed a commit that referenced this pull request Jun 1, 2018
* BUGFIX: Fixes missed MyLib conversion from #86 (#88)
@TheAngryByrd TheAngryByrd deleted the 81-dotnet-templating-dash-issues branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running build.cmd on newly-created scaffold failed to restore
1 participant