Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some code #117

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Clean up some code #117

merged 2 commits into from
Sep 9, 2023

Conversation

jeffreyguenther
Copy link
Member

I missed two awaits and refactored the way the settings patterns are being used.

We should await the results of these promises before advancing.
We want the tasks to complete before we return.
We don't need a function to return this array. A constant will do just
fine.
@jeffreyguenther jeffreyguenther merged commit fd64815 into main Sep 9, 2023
@jeffreyguenther jeffreyguenther deleted the jeff/clean-up branch September 9, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant