Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow Transformer Usage #2

Closed
stefan-kolb opened this issue Jul 25, 2017 · 6 comments
Closed

Shadow Transformer Usage #2

stefan-kolb opened this issue Jul 25, 2017 · 6 comments
Assignees
@TheBoegl
Labels
bug is:fixed issuer feedback

Comments

@stefan-kolb
Copy link

stefan-kolb commented Jul 25, 2017 •
edited by TheBoegl
Loading

Hi,

we tried to replace our transformer patch with your plugin, see JabRef/jabref@565e19e
However, we get the typical errors again.
ERROR StatusLogger Unrecognized format specifier [d].
Are we doing something wrong? Maybe you can help us out!
Thanks, Stefan
@TheBoegl TheBoegl self-assigned this Jul 26, 2017
@TheBoegl
Copy link
Owner

Hi Stefan,

I'll try to look into this at the end of this week.

Best regards,
Sebastian

@stefan-kolb stefan-kolb mentioned this issue Jul 28, 2017
Closed
@TheBoegl
Copy link
Owner

TheBoegl commented Jul 30, 2017 •
edited
Loading

If you use this plugin as library it seems to work.
Can you confirm this?

@stefan-kolb
Copy link
Author

stefan-kolb commented Jul 31, 2017 •
edited
Loading

Yes, looks like this is working. What could be the problem here then?
I'd rather use it as a plugin as it keeps the build file clean.

@TheBoegl TheBoegl added bug and removed question labels Aug 1, 2017
TheBoegl added a commit that referenced this issue Aug 3, 2017
@TheBoegl
add the transformer after evaluating the project
e170d13 
This adds the _Log4jPluginsFileTransformer_ after the gradle project is
 evaluated. Therefore, issue #2 should be fixed.
@TheBoegl
Copy link
Owner

TheBoegl commented Aug 3, 2017

Please have a look at the latest version 2.1.1 which should fix this issue.

@stefan-kolb
Copy link
Author

Looks like it works 👍
Thank you for your help!
Another quick suggestion: I'd move https://github.com/TheBoegl/shadow-log4j-transformer#using-the-gradle-plugin-dsl to the very top in the README as it is the easiest and cleanest solution to use the transformer?!

@TheBoegl
Copy link
Owner

TheBoegl commented Aug 3, 2017

You're welcome!
John Engelman noted correctly that a gradle plugin is overkill to provide just one transformer class. Hence, it is mentioned in the README for the sake of completeness only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBoegl TheBoegl

Labels
bug is:fixed issuer feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBoegl @stefan-kolb