Add set_alignment and get_alignment on InstructionValue. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message on failure. It's still not safe because we don't check whether the value is a memory instruction. Add tests for alignment and volatile getters/setters.
TheDan64
reviewed
Aug 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 60.27% 60.82% +0.55%
==========================================
Files 30 30
Lines 1850 1866 +16
==========================================
+ Hits 1115 1135 +20
+ Misses 735 731 -4
Continue to review full report at Codecov.
|
TheDan64
approved these changes
Sep 3, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to get and set alignment on instructions. Copied the approach of getting and setting volatile. Added tests for volatile too when adding tests for alignment.
Related Issue
Related to issue #110. This doesn't add the type safety discussed in that issue, which is closer to #8 and #16.
How This Has Been Tested
Tests!
Checklist