chore: Run rustfmt
#256
Closed
chore: Run rustfmt
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is the result of running `rustfmt **/*.rs` from the root of this project. The goal is the following: When a user (like me) edits a file, the file is automatically formatted on save; which results in larger diffs than needed. Let's fix the coding styles once and for all thanks to `rustfmt` :-)!
|
Hi, thanks for the PR. I appreciate the effort but unfortunately it will not be accepted. We already have an open issue here: #75 which documents that we're waiting for rustfmt 2.0 so that we can use unstable rustfmt features rather than requiring users to have nightly just to format inkwell. Regarding formatting on save, editors usually allow you to disable format on save on a per-project basis |
|
Yeah, OK. I'm not sure to understand why you don't want to get a clean code base with the current |
|
It should be out relatively soon I hope. There's only one issue left: https://github.com/rust-lang/rustfmt/milestone/8 |
|
Good to know :-)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch is the result of running
rustfmt **/*.rsfrom the root ofthis project. The goal is the following: When a user (like me) edits a
file, the file is automatically formatted on save; which results in
larger diffs than needed. Let's fix the coding styles once and for all
thanks to
rustfmt:-)!