Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stand alone server #9

Closed
wants to merge 3 commits into from

Conversation

ashleyhood
Copy link
Contributor

This is the pull request for issue #7

@TheFox
Copy link
Owner

TheFox commented Aug 2, 2016

You removed a bit too much. The Makefile is needed.

@ashleyhood
Copy link
Contributor Author

Sorry. I was a bit over aggressive ;)

Do you need release.sh as well?

TheFox added a commit that referenced this pull request Aug 3, 2016
@TheFox
Copy link
Owner

TheFox commented Aug 3, 2016

I'm thinking about a less radical way, like this: 6d94ef1
I'll consider the other changes, but rather in separate steps. Maybe I'll also remove release.sh and the changes for .travis.yml and the tests on composer.json you made. smtpd.sublime-project is needed. I don't know if it's a good idea to completely getting rid of bootstrap.php and the scripts in composer.json.

TheFox added a commit that referenced this pull request Aug 3, 2016
TheFox added a commit that referenced this pull request Aug 3, 2016
@ashleyhood
Copy link
Contributor Author

I am happy either way as your solution fixes my issue with composer conflicts. If you want, I will just close this pull request.

@TheFox
Copy link
Owner

TheFox commented Aug 4, 2016

Ok, cool. :)

@TheFox TheFox closed this Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants