Bugfix completed

TheGreyGhost · Feb 13, 2016 · decefab · decefab
1 parent 1214efd
commit decefab
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 37 deletions.
diff --git a/build.gradle b/build.gradle
@@ -20,7 +20,7 @@ plugins {
     id "net.minecraftforge.gradle.forge" version "2.0.2"
 }
 
-version = "1.4"
+version = "1.5"
 group= "thegreyghost" // http://maven.apache.org/guides/mini/guide-naming-conventions.html
 archivesBaseName = "itemtransformhelper"
 

diff --git a/src/main/java/itemtransformhelper/ItemTransformHelper.java b/src/main/java/itemtransformhelper/ItemTransformHelper.java
@@ -11,7 +11,7 @@
 public class ItemTransformHelper
 {
     public static final String MODID = "itemtransformhelper";
-    public static final String VERSION = "1.4";
+    public static final String VERSION = "1.5";
 
     // The instance of your mod that Forge uses.  Optional.
     @Mod.Instance(ItemTransformHelper.MODID)

diff --git a/src/main/java/itemtransformhelper/MenuItemCameraTransforms.java b/src/main/java/itemtransformhelper/MenuItemCameraTransforms.java
@@ -160,38 +160,7 @@ private void alterField(boolean increase)
         break;
       }
       case PRINT: {
-          //todo remove: debug code - add breakpoint here...
-
-////          ItemTransformVec3f testITV3f;
-////
-////          testITV3f = transformVec3f;
-////          TRSRTransformation trTest = new TRSRTransformation(testITV3f);
-////          ItemTransformVec3f backCalc = trTest.toItemTransform();
-////          System.out.format("A initial: rot %s; trans %s; scale %s\n",
-////                            testITV3f.rotation.toString(), testITV3f.translation.toString(), testITV3f.scale.toString());
-////          System.out.format("A final: rot %s; trans %s; scale %s\n",
-////                  backCalc.rotation.toString(), backCalc.translation.toString(), backCalc.scale.toString());
-//
-//          Vector3f rotation = new Vector3f(0, 0, 0);
-//          Vector3f scale = new Vector3f(1, 1, 1);
-//          Vector3f translation = new Vector3f(0, 0, 0);
-//          ItemTransformVec3f testITV3f = new ItemTransformVec3f(rotation, translation, scale);
-//          TRSRTransformationBugFix.TranslationRotationScale trs = new TRSRTransformationBugFix.TranslationRotationScale();
-//          trs.rotation = testITV3f.rotation;
-//          trs.scale = testITV3f.scale;
-//          trs.translation = testITV3f.translation;
-//
-//          TRSRTransformationBugFix trTest = new TRSRTransformationBugFix(trs);
-//          TRSRTransformationBugFix.TranslationRotationScale backCalc = trTest.toItemTransform();
-//          System.out.format("initial: rot %s; trans %s; scale %s\n",
-//                  testITV3f.rotation.toString(), testITV3f.translation.toString(), testITV3f.scale.toString());
-//          System.out.format("final: rot %s; trans %s; scale %s\n",
-//                  backCalc.rotation.toString(), backCalc.translation.toString(), backCalc.scale.toString());
-
-
-
-          // todo: uncomment
-          StringBuilder output = new StringBuilder();
+        StringBuilder output = new StringBuilder();
         output.append("\n\"display\": {\n");
         printTransform(output, "thirdperson", linkToHUDrenderer.itemCameraTransforms.thirdPerson);
         output.append(",\n");

diff --git a/src/main/java/itemtransformhelper/TRSRTransformationBugFix.java b/src/main/java/itemtransformhelper/TRSRTransformationBugFix.java
@@ -250,7 +250,6 @@ public static Triple<Quat4f, Vector3f, Quat4f> svdDecompose(Matrix3f m)
         b.set(m);
         b.mul(t);
 
-        // FIXME: this doesn't work correctly for some reason; not crucial, so disabling for now; investigate in the future.
         //sortSingularValues(b, v);
 
         Pair<Float, Float> p;
@@ -534,7 +533,6 @@ public static boolean isInteger(Matrix4f matrix)
 
     public int rotate(EnumFacing facing, int vertexIndex)
     {
-        // FIXME check if this is good enough
         return vertexIndex;
     }
 

diff --git a/src/main/resources/mcmod.info b/src/main/resources/mcmod.info
@@ -3,7 +3,7 @@
   "modid": "itemtransformhelper",
   "name": "Item Transform Helper",
   "description": "Interactively change the position, scale, and rotation of an item",
-  "version": "1.4",
+  "version": "1.5",
   "mcversion": "${mcversion}",
   "url": "",
   "updateUrl": "",