Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace symbol deprecated since macOS 10.12 #67

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

FranklinYu
Copy link
Contributor

The symbol has been deprecated in favor of the enum since macOS Sierra (10.12). See documentation for details.

The symbol has been deprecated in favor of the enum since macOS Sierra
(10.12). See documentation for details:

https://developer.apple.com/documentation/appkit/nscriticalalertstyle?language=objc
@sreilly
Copy link
Contributor

sreilly commented Mar 31, 2020

Thanks for this update! I'd rather not merge this just yet, because the new symbol is only available as of 10.12 but even the most recent macOS JDK releases support macOS 10.10. Apple's been known to keep deprecated things around for a looong time, so I think we're safe using the old symbol for a while longer.

@mrieser
Copy link

mrieser commented Jul 15, 2020

While working around #70, I also ran into this warning.

Interestingly enough, appbundler currently needs to be built against SDK 10.12 as it uses NSEventModifierFlagNumericPad.

I actually don't know if the binary will successfully run on 10.10, given that it needs SDK 10.12 to build. But maybe it could be an argument to to raise the os requirements of appbundler to macOS 10.12 and integrate this PR.

@sreilly
Copy link
Contributor

sreilly commented Mar 30, 2022

Seeing that recent OpenJDKs need 10.14 or higher I suppose it's pretty safe to require 10.12 😀

@sreilly sreilly merged commit 5946207 into TheInfiniteKind:master Mar 30, 2022
@FranklinYu FranklinYu deleted the fix/deprecate branch March 30, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants