Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in Jenkins support for Coveralls #107

Closed
wants to merge 1 commit into from

Conversation

goosemo
Copy link

@goosemo goosemo commented Apr 25, 2016

This change is Reviewable

@@ -123,6 +123,12 @@ def test_circleci_no_config(self):
assert cover.config['service_job_id'] == '888'
assert cover.config['service_pull_request'] == '9999'

@patch.dict(os.environ, {'JENKINS_HOME': '/var/lib/jenkins', 'BUILD_NUMBER': '888'}, clear=True)
def test_circleci_no_config(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_jenkins_no_config?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll update

@TheKevJames
Copy link
Owner

Hey there! This repo just underwent a change in maintainers -- myself and @goanpeca will be taking over this project. Give us some time to get up-to-speed and we'll make sure to take a look at this PR soon.

@TheKevJames
Copy link
Owner

Moved to #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants