Support git env vars #182
Merged
Support git env vars #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, okay I see the problem is related to non-ascii ENV VARS. |
|
Hi @Themanwithoutaplan , thanks for the contribution! Sorry this took so long to review. I'll make sure this is included in out next release (1.4.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests run using python setup.py test pass but there are failures when running tox that I don't quite understand. It looks like it's related to the env vars so this can hopefully be corrected fairly easily.
In a local setup I have managed to successfully run coveralls for a Mercurial repository: https://coveralls.io/bitbucket/openpyxl/openpyxl